-
Notifications
You must be signed in to change notification settings - Fork 934
Hificnv—copy-number variant caller for PacBio HiFi long-read data #9165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…tainer section in tests/nextflow.config
inemesb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thank you for this module, it will be useful for us as well:) I have added some comments and questions, I have also reviewed the test datasets you added.
|
There are two suggestion from @inemesb that are still open ( for emitting the version ), otherwise it looks good to me. |
inemesb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your great work @chaochaowong, its looking very good! Some tiny nitpicks plus those version emits to consider and you should be all good:)
Co-authored-by: inemesb <[email protected]>
Co-authored-by: inemesb <[email protected]>
Co-authored-by: inemesb <[email protected]>
|
``
@inemesb How did you find those nitpicks??? Is there a tool I can use to catch those tiny mistakes next time? Thank you very much. Moreover, I saw you were involved in merging the test datasets for |
1c2e538 to
2a781c9
Compare
PR checklist
Closes #XXX
versions.ymlfile.labelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile conda