Skip to content

Conversation

@chaochaowong
Copy link
Contributor

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfill software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda

@chaochaowong chaochaowong added the new module Adding a new module label Oct 2, 2025
@chaochaowong chaochaowong self-assigned this Oct 2, 2025
Copy link
Contributor

@inemesb inemesb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thank you for this module, it will be useful for us as well:) I have added some comments and questions, I have also reviewed the test datasets you added.

@chaochaowong
Copy link
Contributor Author

@CaroAMN @inemesb I've resolved all the issues, added testings for all optional inputs, and closed the unnecessary PR on nf-core/test-datasets ! Thank you so much for helping me. This is my first solo on making a module, and I've learned a lot.

@CaroAMN
Copy link
Contributor

CaroAMN commented Nov 11, 2025

There are two suggestion from @inemesb that are still open ( for emitting the version ), otherwise it looks good to me.

Copy link
Contributor

@inemesb inemesb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your great work @chaochaowong, its looking very good! Some tiny nitpicks plus those version emits to consider and you should be all good:)

@chaochaowong
Copy link
Contributor Author

chaochaowong commented Nov 14, 2025

``

Thank you for your great work @chaochaowong, its looking very good! Some tiny nitpicks plus those version emits to consider and you should be all good:)

@inemesb How did you find those nitpicks??? Is there a tool I can use to catch those tiny mistakes next time? Thank you very much. Moreover, I saw you were involved in merging the test datasets for pb-cpg-tools. Are you guying writing the module? I am looking forward to including it to the nf-core/pacvar pipeline once it becomes available. This hificnv is for the pacvar pipeline as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants